feat(notebook): single-page onboarding; Next step navigates via postMessage - #73
Merged
Conversation
…setup Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…llowlist Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bjoaquinc
changed the title
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…_base_url Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…no-op clicks sync Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…to user-facing entries Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The account always has a playground workspace, so drop the pre-connect existence probe and always `connect playground` without --create. The probe treated an unauthenticated `workspace list` as "workspace absent", wrongly appended --create, and surfaced a confusing "already exists" failure. Removes _playground_exists, _workspace_in_list, and the now unused capture_uv_command helper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The onboarding notebook drops its second page ("You're all set" + agent-prompt copy card). It's now a single page — the query workbench — and the "Next step" button that appears after the first query sends the viewer to the organization's setup page.
Navigation uses the parent-mediated
postMessageprotocol agreed in dlt-hub/runtime#1301: the iframe sandbox blocks notebooks from navigating anywhere themselves, so the button posts{type: "dlthub:navigate", route: "org-setup"}and the embedding app validates the route against its allowlist, resolves the org from its own session, and navigates. Requires the runtime-side listener (interactiveRunFrame.tsx) to land.Changes
ActionButtongained aroutetrait. When set, a click posts the navigate message towindow.parent(no-op if nothing listens, e.g. standalone marimo).to_nextusesroute="org-setup".COLUMN_STYLE, and all their CSS. TheClipboardCopywidget is deleted (page 2 was its only user).marimo export session --force-overwrite.href/targetlink,dlt_access.org_setup_url(), and theserve_headless.pyorg-id guard (the parent supplies the org now, so the notebook never reads it).show_notebook.pyderives its URL fromdlt_runtime.urls.workspace_url()+ the active workspace context, instead of parsing config itself. This also fixes the dev URL: non-prod stacks live on the apex (dlthub.dev,dlthub.test;app.dlthub.devdoesn't resolve), which the runtime'sweb_ui_base()knows and our old heuristic got wrong. Verified against prod/test/dev/stage.dlthub workspace connect playground, no--create. The old pre-connect probe read an unauthenticatedworkspace listas "absent", added--create, and hard-failed with a confusingWorkspace 'playground' already exists. Since every account has a playground, the probe (_playground_exists,_workspace_in_list) and the now-unusedcapture_uv_commandare gone.make workspace-local/make workspace-devno longer defaultDLTHUB_CLIENT_SOURCEto../runtime/clients/cli— they use the released PyPI client (explicitDLTHUB_CLIENT_SOURCE=…still overrides). CHANGELOG trimmed to user-facing entries.Tests
make test(168) + ruff/mypy pass — includes snapshot validity/version tests and the compile-all check that picks up the deleted widget.🤖 Generated with Claude Code